xxubai commented on PR #4430: URL: https://github.com/apache/amoro/pull/4430#issuecomment-6072796177
I completed a broader recheck of `9957000`: all 137 bundled package names, their license/notice files, rendered vendored code, and the final JAR. The previous packaging and package-license issues are resolved. The remaining gaps are notices for code embedded inside those packages: - `@swaggerexpert/[email protected]`: ship its upstream `NOTICE`, including the Vladimír Gorej and IETF Trust attributions for the bundled grammar. - `[email protected]`: include the applicable entries from `ThirdPartyNotices.txt`, particularly the Joyent/Node.js path-library notice. `base/common/path.js` is bundled, but its attribution is absent from the release artifacts. - `[email protected]`: include `LICENSES/LICENSE-d3` (BSD-3-Clause, Mike Bostock). The copied `quantile` implementation is retained in the bundle. - `[email protected]`: preserve the embedded fast-deep-equal MIT notice (Evgeny Poberezkin) from `module/core.mjs`; its `_areEquals` implementation is bundled, while the shipped package LICENSE only credits Joachim Wester. Please include these applicable license/notice texts in the packaged legal resources. I found no other blocking issues within this frontend review at this commit; these are the remaining items from the completed recheck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
