zhoujinsong commented on PR #4430:
URL: https://github.com/apache/amoro/pull/4430#issuecomment-6057226555

   > Three issues need fixing:
   > 
   > * Adding `<resources>` overrides the default resource directory. A full 
build produces 60 static files, but the JAR contains none. Please retain 
`src/main/resources`.
   > * Transitive dependencies bundled into the dashboard still lack license 
coverage, including `zrender`, `@ctrl/tinycolor`, and `clipboard`. Please 
collect licenses and required notices from the actual bundle.
   > * `[email protected]` is BSD-3-Clause, but is listed under MIT. Please move it to 
the correct group.
   
   Thanks for reviewing, I have fixed these issues, PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to