hutiefang76 opened a new pull request, #4422:
URL: https://github.com/apache/amoro/pull/4422

   ## Why are the changes needed?
   
   Fixes #4420.
   
   Raw Hive partition values can contain `/`, `%` and `+`. Converting them 
through a generated partition path confuses value data with path separators and 
can break metadata synchronization or upgrades.
   
   ## Brief change log
   
   - Build `PartitionData` directly from each raw value using Iceberg's type 
conversion.
   - Validate the value count against the partition fields.
   - Cover slash-containing strings, verbatim special characters, typed 
multi-column values and lookup by a real Iceberg partition key.
   
   ## How was this patch tested?
   
   - [x] Added deterministic regression tests.
   - [x] Ran tests locally before making this pull request.
   - [ ] Screenshots (not applicable).
   
   JDK 17: all 5 `TestHivePartitionUtil` tests passed.
   
   `./mvnw -pl amoro-format-mixed/amoro-mixed-hive -am -Pskip-dashboard-build 
-Dtest=TestHivePartitionUtil -Dsurefire.failIfNoSpecifiedTests=false test`
   
   `dev/reformat` passed. These are conversion/key-lookup tests; no external 
Hive metastore or full table-upgrade integration run is claimed.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? No.
   - Feature documentation: not applicable; this corrects existing behavior.
   
   AI assistance: DeepSeek and Codex assisted implementation, tests and this 
description.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to