hutiefang76 opened a new pull request, #4421: URL: https://github.com/apache/amoro/pull/4421
## Why are the changes needed? Fixes #4419. The required flag was selecting the optional DDL template, and the optional flag selected the required template. This reverses the meaning of schema history. ## Brief change log - Select `SET NOT NULL` for required columns and `DROP NOT NULL` for optional columns. - Correct the shared descriptor fixture and test both directions through the handler and `DDLReverser`. ## How was this patch tested? - [x] Added deterministic regression tests. - [x] Ran tests locally before making this pull request. - [ ] Screenshots (not applicable). JDK 17: 16 tests passed — 4 focused nullability cases, 10 concrete Iceberg descriptor cases and 2 Paimon descriptor cases. `./mvnw -pl amoro-ams,amoro-format-paimon -am -Pskip-dashboard-build -Dtest=TestSparkMetadataChangeHandler,TestIcebergServerTableDescriptor,TestPaimonServerTableDescriptor -Dsurefire.failIfNoSpecifiedTests=false test` `dev/reformat` passed. ## Documentation - Does this pull request introduce a new feature? No. - Feature documentation: not applicable; this corrects existing behavior. AI assistance: DeepSeek and Codex assisted implementation, tests and this description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
