hutiefang76 opened a new pull request, #4410: URL: https://github.com/apache/amoro/pull/4410
## Why are the changes needed? Fix #4409. `TableController.getTableList` sorts managed entries by type and name before appending unmanaged Hive entries. In a Hive catalog containing a managed Iceberg table and an unmanaged Hive table, the response puts ICEBERG before HIVE, contrary to the comparator applied to the managed list. The combined response should use the same type/name order. ## Brief change log Move the existing type/name comparator after managed and unmanaged Hive entries have been combined. Cover combined ordering, managed-name deduplication, keyword filtering and non-Hive catalogs. ## How was this patch tested? - [x] Add regression tests covering the changed behavior. - [x] Run tests locally before making a pull request. The new suite has 3 tests. On the original implementation, the combined-list and keyword-filtered cases fail; the non-Hive case passes. All 3 pass with the change. ```shell ./mvnw -B -ntp -Pjava11,skip-dashboard-build -pl amoro-ams -am -Dsurefire.failIfNoSpecifiedTests=false -Dtest=TestTableControllerTableList,TestServerCatalog test ``` The selected suites passed on Java 11 and Java 17: 39 tests per JDK, with no failures, errors or skips. The Java 17 run used a clean build and the `java17` profile. Spotless and Checkstyle checks passed. The full test suite and browser tests were not run. ## Documentation - Does this pull request introduce a new feature? no - How is the feature documented? not applicable Code was assisted by DeepSeek v4 Flash via Reasonix 1.39.4; submission text was assisted by Codex. The patch and local test results were reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
