hutiefang76 opened a new pull request, #4403:
URL: https://github.com/apache/amoro/pull/4403

   ## Why are the changes needed?
   
   A non-positive self-optimizing.quota can make the Dashboard table list throw 
during occupation calculation or display a negative quota. Match the minimum 
limit already used by the scheduler.
   
   Fix #4400.
   
   ## Brief change log
   
   - Clamp the proportional quota limit in 
OptimizingUtil.buildTableOptimizeInfo to at least one.
   - Add JUnit 5 tests for zero/negative values, normal quota modes and 
running-task occupation.
   
   ## How was this patch tested?
   
   - [x] New positive and negative regression cases: 5 passed.
   - [x] Existing TestOptimizingUtil integration regression: 1 passed.
   - [x] Local tests, Spotless and Checkstyle passed with Java 11 and Java 17.
   - Original production code fails the zero/negative regression cases.
   - Also ran the same selected tests after `clean` with 
`-Pjava11,skip-dashboard-build`.
   - Command: `./mvnw -B -ntp -Pjava17,skip-dashboard-build -pl amoro-ams -am 
-Dsurefire.failIfNoSpecifiedTests=false 
-Dtest=TestTableOptimizingInfo,TestOptimizingUtil test`.
   - The full suite and the complete CI matrix were not run locally.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable
   
   ## AI assistance
   
   Code was assisted by DeepSeek v4 Flash via Reasonix 1.39.4; submission text 
was assisted by Codex. The patch and local test results were reviewed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to