hutiefang76 opened a new pull request, #4402: URL: https://github.com/apache/amoro/pull/4402
## Why are the changes needed? The Hive upgrade API includes internal watermark settings because `HIDDEN_EXPOSED` stores the string representation of the protected-property set as one key. Add the individual keys so the existing filtering removes them. Fix #4399. ## Brief change log - Add `addAll` for write-protected property names while retaining the existing synthetic set-key filter. - Add JUnit 5 tests calling the actual controller, verifying protected keys and the reflected set key are absent, and normal table/Hive defaults remain. ## How was this patch tested? - Before the patch: the new controller tests run 2 cases with 1 assertion failure on `watermark.table`, 0 errors and 0 skips. - After the patch: 12 tests pass across `TestTableControllerUpgradeProperties`, `TestAmsUtil` and `TestPropertiesUtil`, with no errors or skips. - Maven reactor Spotless and Checkstyle checks pass with Java 11 and Java 17. - Java 17 command: `./mvnw -B -ntp -Pjava17,skip-dashboard-build -pl amoro-ams -am -Dsurefire.failIfNoSpecifiedTests=false -Dtest=TestTableControllerUpgradeProperties,TestAmsUtil,TestPropertiesUtil test`. - Also ran the same selected tests after `clean` with `-Pjava11,skip-dashboard-build`. - Full suite and browser testing were not run. ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable ## AI assistance Code was assisted by DeepSeek v4 Flash via Reasonix 1.39.4; submission text was assisted by Codex. The patch and local test results were reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
