hutiefang76 opened a new issue, #4399: URL: https://github.com/apache/amoro/issues/4399
## What happened? The Hive upgrade property API offers internal `watermark.table` and `watermark.base` settings. `ServerTableProperties.HIDDEN_EXPOSED` adds `WRITE_PROTECTED_PROPERTIES.toString()` as one key but does not add its individual elements. The synthetic key still needs filtering because the API reflects static fields. ## Affects Versions master at 9442f8c0fe86f3199c77c21b730e1d9cf6cfe984. ## What table formats are you seeing the problem on? Mixed-Hive. ## What engines are you seeing the problem on? AMS. ## How to reproduce 1. Call `TableController.getUpgradeHiveTableProperties` with a mocked Javalin context and capture the `OkResponse` map. This is the controller for `GET /api/ams/v1/upgrade/properties`. 2. Check the returned keys: both `watermark.table` and `watermark.base` are present on master. 3. The Hive upgrade property selector consumes these keys in `Properties.vue`. Expected: internal write-protected properties are absent, and editable properties keep their existing defaults. The reproduction was checked at the controller level; browser acceptance was not run. ## Relevant log output The new regression fails on the original code because `watermark.table` is present in the response. After adding the individual protected names, both controller tests pass. ## Anything else Proposed change: add all individual `WRITE_PROTECTED_PROPERTIES` names to the hidden set while retaining the synthetic set-key filter. Add tests for protected names, the reflected set key and editable defaults. This fixes the upgrade options only; it does not resolve the broader table-mutation protections in #1121. ## Are you willing to submit a PR? - [x] Yes I am willing to submit a PR! ## Code of Conduct - [x] I agree to follow this project's Code of Conduct. ## AI assistance Code was assisted by DeepSeek v4 Flash via Reasonix 1.39.4; submission text was assisted by Codex. The patch and local test results were reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
