zhoujinsong commented on PR #3211: URL: https://github.com/apache/amoro/pull/3211#issuecomment-2362698197
> Here, the definition of the catalog's property is completely unrestricted. I suggest keeping the original configuration validation. What do others think? @zhongqishang Thanks for the review, I have made some changes based on the comments. I removed the catalog properties limit from the catalog factory. I hope to open up more catalog properties at this stage. I feel that it may not be possible to list all the catalog properties we wish to support for the time being. And I found the same implementation in Iceberg and Paimon Flink catalog factory: https://github.com/apache/iceberg/blob/main/flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java#L133 https://github.com/apache/paimon/blob/master/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/FlinkCatalogFactory.java#L47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
