Aireed commented on code in PR #3211:
URL: https://github.com/apache/amoro/pull/3211#discussion_r1767843472
##########
amoro-format-iceberg/src/test/java/org/apache/amoro/catalog/BasicMixedCatalog.java:
##########
@@ -214,7 +215,7 @@ public Map<String, String> properties() {
protected TableMeta getMixedTableMeta(TableIdentifier identifier) {
TableMeta tableMeta;
try {
- tableMeta =
getClient().getTable(MixedFormatCatalogUtil.amsTaleId(identifier));
+ tableMeta = getClient().getTable(CatalogUtil.amsTaleId(identifier));
Review Comment:
`tableMeta = getClient().getTable(CatalogUtil.amsTaleId(identifier));`
I think `amsTaleId` should be `amsTableId`, previously it was probably
misspelled.
##########
amoro-format-mixed/amoro-mixed-flink/amoro-mixed-flink-common/src/main/java/org/apache/amoro/flink/table/UnifiedDynamicTableFactory.java:
##########
@@ -42,12 +42,12 @@
* AmoroDynamicTableFactory is a factory for creating dynamic table sources
and sinks. It implements
Review Comment:
replace AmoroDynamicTableFactory with UnifiedDynamicTableFactory in comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
