shivaam commented on code in PR #64939:
URL: https://github.com/apache/airflow/pull/64939#discussion_r3074726370
##########
airflow-core/src/airflow/models/backfill.py:
##########
@@ -524,15 +529,18 @@ def _handle_clear_run(
run_on_latest_version=run_on_latest,
)
- # Update backfill_id and run_type in DagRun table
+ # Update backfill_id, run_type, and optionally conf in DagRun table
+ update_values: dict = dict(
+ backfill_id=backfill_id,
+ run_type=DagRunType.BACKFILL_JOB,
+ triggered_by=DagRunTriggeredByType.BACKFILL,
+ )
+ if dag_run_conf is not None:
+ update_values["conf"] = dag_run_conf
session.execute(
update(DagRun)
.where(DagRun.logical_date == info.logical_date, DagRun.dag_id ==
dag.dag_id)
- .values(
- backfill_id=backfill_id,
- run_type=DagRunType.BACKFILL_JOB,
- triggered_by=DagRunTriggeredByType.BACKFILL,
- )
+ .values(**update_values)
Review Comment:
Pre-existing pattern. The same UPDATE was already setting backfill_id,
run_type, triggered_by with this filter before our PR. We didn't introduce it.
Legitimate concern but this is out of scope for this PR. I can handle it in a
separate PR or even this PR if the maintainers thing it is a good idea to
handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
