shivaam commented on code in PR #64939:
URL: https://github.com/apache/airflow/pull/64939#discussion_r3074709726


##########
airflow-core/src/airflow/models/backfill.py:
##########
@@ -249,6 +249,7 @@ def _validate_backfill_params(
     from_date: datetime,
     to_date: datetime,
     reprocess_behavior: ReprocessBehavior | None,
+    dag_run_conf: dict | None = None,
 ) -> None:

Review Comment:
   Pydantic still sends {} for omitted conf, persists as {}. No change from 
before our PR.
   CLI today (pre-existing): Can pass None, which SQLAlchemy either coerces or 
fails on.
   For the UI follow-up PR: We'd need to make the column nullable to preserve 
the None{} distinction. So this is a concern for the follow-up UI PR, not this 
one.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to