ashb commented on code in PR #54813: URL: https://github.com/apache/airflow/pull/54813#discussion_r2321850410
########## airflow-core/src/airflow/utils/log/file_task_handler.py: ########## @@ -73,7 +73,7 @@ """Information _about_ the log fetching process for display to a user""" RawLogStream: TypeAlias = Generator[str, None, None] """Raw log stream, containing unparsed log lines.""" -LegacyLogResponse: TypeAlias = tuple[LogSourceInfo, LogMessages] +LegacyLogResponse: TypeAlias = tuple[LogSourceInfo, LogMessages | None] Review Comment: Rather than "Legacy" I think we should call this something like `LogResponse` and `StreamingLogResponse` -- as unless I'm missing something there could always be log providers that don't implement the stream method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
