jason810496 commented on code in PR #54813:
URL: https://github.com/apache/airflow/pull/54813#discussion_r2320887347
##########
providers/alibaba/src/airflow/providers/alibaba/cloud/log/oss_task_handler.py:
##########
@@ -95,6 +95,9 @@ def read(self, relative_path, ti: RuntimeTI) ->
tuple[LogSourceInfo, LogMessages
return messages, logs
return messages, None
+ def stream(self, relative_path: str, ti: RuntimeTI) -> LogResponse:
+ raise NotImplementedError
Review Comment:
I just added another `RemoteLogStreamIO` Protocal and having
`REMOTE_TASK_LOG` annotated as `REMOTE_TASK_LOG: RemoteLogIO |
RemoteLogStreamIO | None = None`.
Additionally, mypy is not waring and the CI have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
