TJaniF commented on code in PR #52891:
URL: https://github.com/apache/airflow/pull/52891#discussion_r2189379175
##########
airflow-core/src/airflow/ui/public/i18n/locales/de/dag.json:
##########
@@ -25,12 +25,17 @@
"logs": {
"allLevels": "Alle Protokoll-Stufen",
"allSources": "Alle Quellen",
+ "critical": "KRITISCH",
Review Comment:
Yeah, I agree with @shahar1 since the logs will show the English terms it
makes sense to leave them in English in the filter as well.
Also I just tested it (see gif attached) and only the entries in the
dropdown are renamed, not the ones when selected, which I think might lead to
confusion, so another point for leaving the log levels in English.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
