ashb commented on code in PR #50775:
URL: https://github.com/apache/airflow/pull/50775#discussion_r2097677082
##########
task-sdk/tests/task_sdk/execution_time/test_supervisor.py:
##########
@@ -1490,6 +1491,7 @@ def watched_subprocess(self, mocker):
def test_handle_requests(
self,
mock_secrets_masker,
+ mock_mask_secret,
Review Comment:
Why do we need both mock_secrets_masker and mock_mask_secret? That feels
like we over mocking -- I don't think we should need both. Could we assert
something on `mock_secrets_masker.return_value` without having to add an extra
mock? Or can we get rid of one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
