uranusjr commented on code in PR #50775:
URL: https://github.com/apache/airflow/pull/50775#discussion_r2097569399
##########
task-sdk/tests/task_sdk/execution_time/test_supervisor.py:
##########
@@ -1524,6 +1526,11 @@ def test_handle_requests(
next(generator)
msg = message.model_dump_json().encode() + b"\n"
generator.send(msg)
+
+ if isinstance(message, GetVariable):
+ mock_mask_secret.assert_called_once()
+ mock_mask_secret.assert_called_with("test_value", "test_key")
Review Comment:
This has a change to be sliently never checked if we accidentally change the
GetVariable fixture. It’s probably better to check these in a separate test.
##########
task-sdk/tests/task_sdk/execution_time/test_supervisor.py:
##########
@@ -1524,6 +1526,11 @@ def test_handle_requests(
next(generator)
msg = message.model_dump_json().encode() + b"\n"
generator.send(msg)
+
+ if isinstance(message, GetVariable):
+ mock_mask_secret.assert_called_once()
+ mock_mask_secret.assert_called_with("test_value", "test_key")
Review Comment:
This has a chance to be sliently never checked if we accidentally change the
GetVariable fixture. It’s probably better to check these in a separate test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
