Nice work! I did some review on the pull request. For me the fundamental things that need to happen before merging this initial implementation are:
* UX (review by a designer) * Monitoring for changes * Unit tests * Integration tests Seems like IOMMU Grouups, Topology, USB, and SCSI could be follow up pull requests ... there are enough fundamentals above that will make this first Device pull request very big. Stef On 01.12.2016 16:04, Marek Libra wrote: > Hi, > > I pushed PR with new Hardware Devices plugin [1]. > > Please note, it's recent purpose is to get early feedback, there's todo > list to finish before ready to merge. > > So far, there's support for PCI where I would like to finalize IOMMU > Groups and (maybe) NUMA topology view. > USB and (maybe) SCSI Bus are recently missing but are planed. > > The code needs to be cleaned-up. Major focus is on functionality and UX now. > > Thanks for your feedback! > Marek > > [1] https://github.com/cockpit-project/cockpit/pull/5523 > [2] > https://github.com/cockpit-project/cockpit/wiki/Feature:-Hardware-Devices > > ------------------------------------------------------------------------ > > *From: *"Andreas Nilsson" <[email protected]> > *To: *[email protected] > *Sent: *Wednesday, October 5, 2016 11:13:50 AM > *Subject: *Re: idea/rfc: device screen in cockpit > > On 2016-10-05 11:06, Marek Libra wrote: > > Hi, > > I'm resending to make sure we can agree on the stated scope and > appropriateness of this new package for the Cockpit. > > Thanks for your comments, > Marek > > > Hi, and sorry I didn't have time to look into it yet. > I have a bunch of other stuff going on at the same time. > I'll try to take a look either today or tomorrow. > - Andreas > > _______________________________________________ > cockpit-devel mailing list -- [email protected] > To unsubscribe send an email to > [email protected] > > > > > _______________________________________________ > cockpit-devel mailing list -- [email protected] > To unsubscribe send an email to [email protected] > _______________________________________________ cockpit-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
