On Tue, 7 Apr 2026 14:25:51 GMT, Archie Cobbs <[email protected]> wrote:
>> make/JrtfsJar.gmk line 54:
>>
>>> 52: $(eval $(call SetupJavaCompilation, BUILD_JRTFS, \
>>> 53: COMPILER := interim, \
>>> 54: DISABLED_WARNINGS := options suppression, \
>>
>> Are you sure this must be changed? It's compiling the code that goes into
>> jrt-fs.jar that is compiled with --release 8.
>
>> Are you sure this must be changed? It's compiling the code that goes into
>> jrt-fs.jar that is compiled with --release 8.
>
> Hi @AlanBateman,
>
> Without that change, the following error would occur during `make test
> TEST="langtools_javac"`:
>
> Compiling up to 30 files for BUILD_JRTFS
> /opt/jdk/src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java:70:
> warning: [suppression] unnecessary warning suppression: "removal"
> @SuppressWarnings("removal")
> ^
> error: warnings found and -Werror specified
> 1 error
> 1 warning
>
> Like most new warnings, this one is not restricted by source level causing
> the meaning of `-Xlint:all` to change, hence the need for the exclusion.
I wonder if we can remove the `@SuppressWarnings` from this method. SM was not
deprecated in JDK 8 so `@SuppressWarnings` is not need for that compilation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25167#discussion_r3046403751
