On Mon, 6 Apr 2026 21:37:16 GMT, Archie Cobbs <[email protected]> wrote:
>> This PR adds a new compiler warning for `@SuppressWarnings` annotations that >> don't actually suppress any warnings. >> >> Summary of code changes: >> >> * Add new warning and associated lint category `"suppression"` >> * Update `LintMapper` to keep track of which `@SuppressWarnings` >> suppressions have been validated ¹ >> * Update `Log.warning()` so it validates any current suppression of the >> warning's lint category in effect. >> * Add a new `validate` parameter to `Lint.isEnabled()` and >> `Lint.isSuppressed()` that specifies whether to also validate any current >> suppression. >> * Add `Lint.isActive()` to check whether a category is enabled _or_ >> suppression of the category is being tracked - in other words, whether the >> warning calculation needs to be performed. Used for non-trivial warning >> calculations. >> * Add `-Xlint:-suppression` flags to `*.gmk` build files so the build >> doesn't break >> >> ¹ The suppression of a lint category is "validated" as soon as it suppresses >> some warning in that category > > Archie Cobbs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 142 commits: > > - Merge branch 'master' into JDK-8344159. > - Merge branch 'master' into JDK-8344159 to fix conflicts. > - Merge branch 'master' into JDK-8344159 to fix conflicts. > - Update copyrights to 2026. > - Merge branch 'master' into JDK-8344159 > - Merge branch 'master' into JDK-8344159 > - Merge branch 'master' into JDK-8344159 > - Suppress new unnecessary suppresion warnings created by recent commits. > - Merge branch 'master' into JDK-8344159 > - Merge branch 'master' into JDK-8344159 to fix conflict. > - ... and 132 more: https://git.openjdk.org/jdk/compare/e7969288...f34fbb0d make/JrtfsJar.gmk line 54: > 52: $(eval $(call SetupJavaCompilation, BUILD_JRTFS, \ > 53: COMPILER := interim, \ > 54: DISABLED_WARNINGS := options suppression, \ Are you sure this must be changed? It's compiling the code that goes into jrt-fs.jar that is compiled with --release 8. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25167#discussion_r3043147192
