ioeric added inline comments.
================ Comment at: unittests/clangd/QualityTests.cpp:273 }); - SymbolRelevanceSignals Ctor; - Ctor.merge(CodeCompletionResult(CtorDecl, /*Priority=*/0)); - - EXPECT_EQ(Cls.Scope, SymbolRelevanceSignals::GlobalScope); - EXPECT_EQ(Ctor.Scope, SymbolRelevanceSignals::GlobalScope); + SymbolQualitySignals Q; + Q.merge(CodeCompletionResult(CtorDecl, /*Priority=*/0)); ---------------- sammccall wrote: > This looks like it duplicates part of the test below, and removes a sensible > test for scopes on constructors? Oops, this was an accidental change... Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49667 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
