benhamilton accepted this revision.
benhamilton added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:222
+ [MatchedDecl](std::string const &s) {
+ auto Acronym = llvm::Regex("^" + s + "$");
+ return Acronym.match(MatchedDecl->getName());
----------------
Please be aware this will change the match from running a single regular
expression to running ~ 70 regular expressions on every single `@property`. I
would expect this to perform pretty poorly.
================
Comment at: test/clang-tidy/objc-property-declaration.m:24
@property(assign, nonatomic) int enableGLAcceleration;
+@property(assign, nonatomic) int ID;
@end
----------------
Wizard wrote:
> benhamilton wrote:
> > Please add a test for a built-in regex (4G) as well as a custom regex in
> > the other test file.
> Unable to add single property test of 4G because it is illegal to use digit
> as the first character of property name.
Ah, of course.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46374
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
