benhamilton requested changes to this revision.
benhamilton added inline comments.
This revision now requires changes to proceed.
================
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:222
+ [MatchedDecl](std::string const &s) {
+ return s == MatchedDecl->getName();
+ })) {
----------------
`s` is a regular expression here, so you need to match it using `llvm::Regex`,
not `==`.
Why not just update `validPropertyNameRegex()` to handle this case?
================
Comment at: test/clang-tidy/objc-property-declaration.m:24
@property(assign, nonatomic) int enableGLAcceleration;
+@property(assign, nonatomic) int ID;
@end
----------------
Please add a test for a built-in regex (4G) as well as a custom regex in the
other test file.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46374
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
