aaron.ballman added inline comments.
================ Comment at: clang-tidy/tool/ClangTidyMain.cpp:150-152 +Show color diagnostics. If not specified, +defaults to on when a color-capable terminal +is detected.)"), ---------------- itessier wrote: > itessier wrote: > > aaron.ballman wrote: > > > I think this raw string can be reflowed a bit? > > > > > > Instead of "defaults to on", how about "Defaults to true when a > > > color-capable terminal is detected."? > > I copied that part from the -fcolor-diagnostics flag to be consistent. I > > don't changing "on" to "true" if you prefer that instead. > That should have read "I don't mind changing..." I'd say let's go ahead and change it, and once this patch lands, change the help text for `-fcolor-diagnostics` in a follow-up. https://reviews.llvm.org/D41720 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
