ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM. (See the comment about changing the comment, though) ================ Comment at: clangd/index/SymbolCollector.cpp:75 + // Skip nameless declarations. + if (ND->getDeclName().isEmpty()) + return true; ---------------- hokein wrote: > ilya-biryukov wrote: > > What are those declarations exactly? > This would ignore anonymous declarations, e.g. anonymous class/enum. See the > unittest. Thanks for clarifying. Maybe we could change the comment to say "anonymous" instead of "nameless"? This is what bit got me confused. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42074 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
