mstorsjo added a comment.

In https://reviews.llvm.org/D41764#968318, @smeenai wrote:

> I think `LIBCXX_HAS_WIN32_THREAD_API` would be more consistent with the 
> existing configuration define names?


That sounds good to me too. I can update the patch later, or before committing 
if it's otherwise ok.



================
Comment at: CMakeLists.txt:277
   endif()
+  if(LIBCXX_HAS_WIN32_THREADS)
+    message(FATAL_ERROR "LIBCXX_HAS_WIN32_THREADS can only be set to ON"
----------------
smeenai wrote:
> The inconsistent usage of `if(` vs `if (` in this file is annoying me haha. 
> Not this diff's fault of course, but still.
Oh, yes... The new lines here were copypasted from the pthread ones a bit 
further above, explaining the inconsistency.


Repository:
  rCXX libc++

https://reviews.llvm.org/D41764



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to