smeenai added a comment. I think `LIBCXX_HAS_WIN32_THREAD_API` would be more consistent with the existing configuration define names?
================ Comment at: CMakeLists.txt:277 endif() + if(LIBCXX_HAS_WIN32_THREADS) + message(FATAL_ERROR "LIBCXX_HAS_WIN32_THREADS can only be set to ON" ---------------- The inconsistent usage of `if(` vs `if (` in this file is annoying me haha. Not this diff's fault of course, but still. Repository: rCXX libc++ https://reviews.llvm.org/D41764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
