ilya-biryukov added inline comments.
================ Comment at: clangd/Context.h:79 +/// Otherwise returns an empty Context. +Context &globalCtx(); + ---------------- bkramer wrote: > This is a giant code smell. If we want the context route, please pass > contexts everywhere. I really don't want this kind of technical debt in > clangd now. I'm with you on this one, but I think @sammccall was keen on having the global context. The main reason was to always have access to **some** loggers and tracers, even when it's hard to pass the Context into the function. It's perfectly easy to remove all usages of `globalCtx()`, currently only 8 usages to get rid of. However, I'd wait for Sam's comment before doing that. https://reviews.llvm.org/D40485 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
