mstorsjo added a comment. In https://reviews.llvm.org/D39365#910713, @theraven wrote:
> Sorry - it looks as if I read the diff back to front. I seem to be less > awake than I thought today... > > Reading the diff the correct way around, this seems like a definite > improvement. Ok, thanks! Then it's just left to see if @rnk agrees with @compnerd 's reasoning. >>> though the use of `PRIxPTR` vs `PRIXPTR` seems inconsistent (as is the >>> original use of `%x` vs `%X`. >> >> Yes, I've kept these as inconsistent as they were originally - if peferred I >> can make the ones I touch consistently either upper or lower case. > > I'd generally prefer `PRIxPTR`, because most of the time I either don't care > or want to copy and paste for comparison with objdump output (which uses > lower case). Ok, I'll make it consistent in the next update or when committing. https://reviews.llvm.org/D39365 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
