steffenlarsen wrote: Absolutely! This is not directly related to the refactoring of cl::opt, but a part of a series of patches cleaning up "actually constant" global state in LLVM and Clang. It's by no mean urgent or critical, but making sure these objects are constant ensures future contributors better understand the intentions and uses of the objects, hopefully avoiding the addition of additional global state sneaking into existing global state.
Other patches in the series: https://github.com/llvm/llvm-project/pull/183287, https://github.com/llvm/llvm-project/pull/183478, https://github.com/llvm/llvm-project/pull/183477 & https://github.com/llvm/llvm-project/pull/183295 https://github.com/llvm/llvm-project/pull/184352 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
