kovdan01 wrote: > They're macros that are used, and are useful on their own so upstreaming > still seems sensible? they were just for the unwind work I had just genuinely > assumed they were already upstreamed :D
@ojhunt Sure, we can do that. But if doing that, it's at least worth deleting `ptrauth_function_pointer_type_discriminator` from this PR since it was already introduced in #163456. And other comments, e.g. adding tests for non-trivial functionality and avoiding UB when using unions, should also be addressed prior to merging :) https://github.com/llvm/llvm-project/pull/161027 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
