compnerd marked 2 inline comments as done. compnerd added inline comments.
================ Comment at: lib/AST/MicrosoftMangle.cpp:988 + if (const auto *RD = dyn_cast<RecordDecl>(DC)) + mangleName(RD); + else ---------------- compnerd wrote: > efriedma wrote: > > The call to mangleName() looks a little weird... I would have expected a > > call to mangleUnqualifiedName or something like that. (If there's some > > reason for the asymmetry, a brief comment explaining it would be fine.) > Accounting for the parameter like we do for lambdas makes this unnecessary. Err, still need it for the fields; added a comment. Repository: rL LLVM https://reviews.llvm.org/D34523 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
