erichkeane wrote:

> +1 for the inline helper. But if we go down that path, maybe we could add an 
> optional parameter to `InsertNode` and make it the helper we're talking about?
> 
> ```c++
> [[always_inline]] Ret InsertNode(<args>, llvm::FoldingSetNodeID* IDForAssert 
> = nullptr) {
>   assert(!IDForAssert || IDForAssert == ...);
>   return InsertNodeImpl(<args>);
> }
> ```

That would be acceptable as well to me.

https://github.com/llvm/llvm-project/pull/157692
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to