carlosgalvezp wrote:

> In one of the files we check. Would we still get warnings for UserCode?

Yes, we would. For example, a simple:

```
int x = 0;
assert(reinterpret_cast<int*>(x) == nullptr);
```

Triggers `cppcoreguidelines-pro-type-reinterpret-cast` for the use of 
`reinterpret_cast`, even if it's called inside a macro.

It's also my understanding that clang-tidy already filters out all system 
header diagnostics, _before_ doing macro expansion:

https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp#L569




https://github.com/llvm/llvm-project/pull/151035
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to