dschuff wrote: This change looks fine. Regarding nontrapping call, In general I think we probably shouldn't have clang builtins for functionality that can be implemented in code on top of existing builtins. Builtins are basically language extensions (but often without the extensive vetting that language design usually includes), and as part of a low-level platform, they are hard to change. Also if we start with something minimal it's easier to push functionality down the platform stack in the future (e.g. by adding the builtin later).
https://github.com/llvm/llvm-project/pull/150201 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
