CaseyCarter added a comment.

In https://reviews.llvm.org/D33741#769381, @EricWF wrote:

> In https://reviews.llvm.org/D33741#769371, @STL_MSFT wrote:
>
> > I haven't seen min/max test failures, probably because our CRT/STL headers 
> > never drag in Windows.h.
>
>
> Ah, that makes sense. Libc++ currently does although the plan is to fix that 
> eventually. :-S


Are you aware that Windows.h won't define `min` and `max` if you define 
`NOMINMAX` before including it? You could solve the problem by adding 
`-DNOMINMAX` to your test compile parameters.


https://reviews.llvm.org/D33741



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to