EricWF created this revision.

After changing libc++ to push/pop the min/max macros on Windows we have a bunch 
of new test  failures, caused by tests using min/max. I would like to use 
test_macros.h to undefine it.

Would this work for you? How have you been dealing with these failures?


https://reviews.llvm.org/D33741

Files:
  test/support/test_macros.h


Index: test/support/test_macros.h
===================================================================
--- test/support/test_macros.h
+++ test/support/test_macros.h
@@ -223,6 +223,14 @@
 }
 #endif
 
+#if defined(min)
+#undef min
+#endif
+
+#if defined(max)
+#undef max
+#endif
+
 #if defined(__GNUC__)
 #pragma GCC diagnostic pop
 #endif


Index: test/support/test_macros.h
===================================================================
--- test/support/test_macros.h
+++ test/support/test_macros.h
@@ -223,6 +223,14 @@
 }
 #endif
 
+#if defined(min)
+#undef min
+#endif
+
+#if defined(max)
+#undef max
+#endif
+
 #if defined(__GNUC__)
 #pragma GCC diagnostic pop
 #endif
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to