================ @@ -348,6 +348,30 @@ parseSanitizeSkipHotCutoffArgs(const Driver &D, const llvm::opt::ArgList &Args, return Cutoffs; } +// Given a set of mismatched bits, TrapOnly (bits the user asked to trap but +// that aren’t actually enabled), emit a warning based on -fsanitize-trap=NAME +static void diagnoseTrapOnly(const Driver &D, SanitizerMask &TrapOnly) { +// Double pass: one for sanitizer groupings, one for leaves (ex: undefined vs. ---------------- delcypher wrote:
For clarity you split this comment. One for the bit where you handle group names, and one for the individual sanitizer name (and put the comment next the code where we do this). https://github.com/llvm/llvm-project/pull/147997 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits