NoQ added inline comments.

================
Comment at: lib/StaticAnalyzer/Core/Store.cpp:440
   //  well, although in reality we should return the offset added to that
-  //  value.
+  //  value. See also the similar FIXME in getLValueFieldOrIvar().
   if (Base.isUnknownOrUndef() || Base.getAs<loc::ConcreteInt>())
----------------
NoQ wrote:
> Note that this code doesn't really trigger; we return `UnknownVal()` 
> somewhere above, as shown on the newly added tests. I suspect we may be 
> missing valid null dereferences because of that; will have a look.
This is also addressed by  D32291.


https://reviews.llvm.org/D31982



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to