AaronBallman wrote:

> Hi @AaronBallman, bothering you again. I have a doubt about the merge of the 
> following case: ![屏幕截图 2025-04-04 
> 081652](https://private-user-images.githubusercontent.com/170909871/430177806-ce592ae1-b02a-45bf-aece-55e3a175a01f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDM3NjcyODYsIm5iZiI6MTc0Mzc2Njk4NiwicGF0aCI6Ii8xNzA5MDk4NzEvNDMwMTc3ODA2LWNlNTkyYWUxLWIwMmEtNDViZi1hZWNlLTU1ZTNhMTc1YTAxZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNDA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDQwNFQxMTQzMDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04YmU4OWViZWVhYzBlODQzMDZlMjUzNzEyYjY1MzFhYzM4NjgzODZkYmU0OGQ2NWY1ODZhZGRiYTAwZmJmOWJhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.bK28LB2tf3qoAdhjsdlDgLrLiOUgHwGEae52w9aviK8)
> 
> There is a lot of content that is `No documentation`, and to merge these 
> entries would be to create a very large entry, like this: ![屏幕截图 2025-04-04 
> 082342](https://private-user-images.githubusercontent.com/170909871/430178685-ef047724-5ac0-4721-928f-5cae5cee1f83.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDM3NjcyODYsIm5iZiI6MTc0Mzc2Njk4NiwicGF0aCI6Ii8xNzA5MDk4NzEvNDMwMTc4Njg1LWVmMDQ3NzI0LTVhYzAtNDcyMS05MjhmLTVjYWU1Y2VlMWY4My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNDA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDQwNFQxMTQzMDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yOWEyOTcxMGViZWU5NzM1MmVhODhiY2JkMzlkZWU5M2YxYzA3YmM2NTI3MjEwZWRlY2Y0NDA2ZWZjMGEwY2Y1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.UIqjxy_6eym15tVGz8Q6PHulB91Ld-F7YYRw1SFIRk0)
> 
> It doesn't look pretty, so if this doesn't have any impact, I'll follow this 
> proposal.

Oh yeah, that is not a good outcome. :-) I think `Undocumented` is a special 
case. For this patch, I would not merge if the category is `Undocumented`. In a 
completely separate patch, it might make sense to combine the `Undocumented` 
attributes into their own list that's a single table of the supported syntaxes, 
with one row per undocumented attribute. Then we're not repeating as much 
content such as `No documentation.` or the headings + the spellings.

https://github.com/llvm/llvm-project/pull/134089
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to