AaronBallman wrote:

> > Oh yeah, that is not a good outcome. :-) I think Undocumented is a special 
> > case. For this patch, I would not merge if the category is Undocumented.
> 
> @AaronBallman Oh, I forgot the other merged entry that is slightly smaller 
> compared to `Undocumented` like this:
> 
> ![屏幕截图 2025-04-04 
> 200659](https://private-user-images.githubusercontent.com/170909871/430370536-f04e1099-966d-4158-9ddb-1b130a795146.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDM3Njk1MzAsIm5iZiI6MTc0Mzc2OTIzMCwicGF0aCI6Ii8xNzA5MDk4NzEvNDMwMzcwNTM2LWYwNGUxMDk5LTk2NmQtNDE1OC05ZGRiLTFiMTMwYTc5NTE0Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNDA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDQwNFQxMjIwMzBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jZjcxOGYwZmY2NjRhOGEyNjEzMTRiNDg4MWRiMGE5MzRjZjgxOGUwMDE4OWE3NTA3OTczMTA1YjMxYmMzN2E0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Zrz8vKcU3KNaBeusO8vphWEoYeFDeWNOXuOIFrcviOg)
> 
> ![屏幕截图 2025-04-04 
> 195903](https://private-user-images.githubusercontent.com/170909871/430370018-b0f155a9-233f-4b98-b20c-8f8343516197.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDM3Njk1MzAsIm5iZiI6MTc0Mzc2OTIzMCwicGF0aCI6Ii8xNzA5MDk4NzEvNDMwMzcwMDE4LWIwZjE1NWE5LTIzM2YtNGI5OC1iMjBjLThmODM0MzUxNjE5Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNDA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDQwNFQxMjIwMzBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMmYyYmY0ODMwNzY4YmEyYjYwZWE1MTkxYzQ5ODQ0OGE0MzE0YjNkMTcwNzdlNWQzNTU3ZDMzZDA1OTFmZTE5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.jWlLLrHy_hbiP9pPhWPVoVvQAgIQ3OzI9ziG45OuJyY)
> 
> Similarly, it doesn't look very pretty.



> > Oh yeah, that is not a good outcome. :-) I think Undocumented is a special 
> > case. For this patch, I would not merge if the category is Undocumented.
> 
> @AaronBallman Oh, I forgot the other merged entry that is slightly smaller 
> compared to `Undocumented` like this:
> 
> ![屏幕截图 2025-04-04 
> 200659](https://private-user-images.githubusercontent.com/170909871/430370536-f04e1099-966d-4158-9ddb-1b130a795146.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDM3Njk1MzAsIm5iZiI6MTc0Mzc2OTIzMCwicGF0aCI6Ii8xNzA5MDk4NzEvNDMwMzcwNTM2LWYwNGUxMDk5LTk2NmQtNDE1OC05ZGRiLTFiMTMwYTc5NTE0Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNDA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDQwNFQxMjIwMzBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jZjcxOGYwZmY2NjRhOGEyNjEzMTRiNDg4MWRiMGE5MzRjZjgxOGUwMDE4OWE3NTA3OTczMTA1YjMxYmMzN2E0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Zrz8vKcU3KNaBeusO8vphWEoYeFDeWNOXuOIFrcviOg)
> 
> ![屏幕截图 2025-04-04 
> 195903](https://private-user-images.githubusercontent.com/170909871/430370018-b0f155a9-233f-4b98-b20c-8f8343516197.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDM3Njk1MzAsIm5iZiI6MTc0Mzc2OTIzMCwicGF0aCI6Ii8xNzA5MDk4NzEvNDMwMzcwMDE4LWIwZjE1NWE5LTIzM2YtNGI5OC1iMjBjLThmODM0MzUxNjE5Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNDA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDQwNFQxMjIwMzBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMmYyYmY0ODMwNzY4YmEyYjYwZWE1MTkxYzQ5ODQ0OGE0MzE0YjNkMTcwNzdlNWQzNTU3ZDMzZDA1OTFmZTE5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.jWlLLrHy_hbiP9pPhWPVoVvQAgIQ3OzI9ziG45OuJyY)
> 
> Similarly, it doesn't look very pretty.

CC @erichkeane for opinions, but I think this is... ugly-but-reasonable. 
Ideally, I'd like to see those split off (cf in one group, ns in another, etc) 
with different documentation given that these are presumably doing different 
things. But as it stands, I think this is better than repeating the same 
information 15 times.

https://github.com/llvm/llvm-project/pull/134089
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to