teresajohnson wrote: > > Thanks for sending this for review! I've only just skimmed the PR so far, > > and need to dig more into it. However, it is massive. It's nice to see how > > it all fits together, but for the purpose of reviewing and upstreaming, > > could you split it up into multiple PRs? I.e. the LLVM only changes (with > > your llvm-lto2 tests), then the lld changes, followed by the clang driver > > changes/tests? > > Apologies. This was about as small as I could get the change whilst having > something functional/useful. I will split up the change as suggested and open > a new PR. Meanwhile, I plan to leave this open for design comments - please > let me know if that is acceptable?
No worries and as mentioned it is good to see the full picture. Just easier to review in smaller pieces. That sounds like a great plan, thanks! https://github.com/llvm/llvm-project/pull/126654 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
