Hana =?utf-8?q?Dusíková?= <hani...@hanicka.net>, Hana =?utf-8?q?Dusíková?= <hani...@hanicka.net> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/98...@github.com>
================ @@ -8075,6 +8089,64 @@ class ExprEvaluatorBase return StmtVisitorTy::Visit(Source); } + bool VisitAtomicExpr(const AtomicExpr *E) { + if (!EvaluateAtomicOrder(E, Info)) ---------------- AaronBallman wrote: Is it intentional that there's no check for C++26 anywhere to reject these uses in earlier language modes? If you intend for this to be an extension in older modes, that seems reasonable to me, but you should update `clang/docs/LanguageExtensions.rst` to explicitly document the extension, add the usual pre-compat/extension warnings, tests for those two new diagnostics, and add a `RUN` line for an older language mode to your larger functionality tests. https://github.com/llvm/llvm-project/pull/98756 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits