================
@@ -1949,24 +1955,48 @@ bool SPIRVInstructionSelector::selectSign(Register 
ResVReg,
   return Result;
 }
 
+bool SPIRVInstructionSelector::selectWaveNOpInst(Register ResVReg,
+                                                 const SPIRVType *ResType,
+                                                 MachineInstr &I,
+                                                 unsigned Opcode,
+                                                 unsigned OperandCount) const {
+  assert(I.getNumOperands() == OperandCount);
----------------
farzonl wrote:

Number of operands per opcode is already determined in the tablegen. Nothing is 
going to change that. This just adds a pain point for users of this function 
where they think they can specify the operand length first build and test fails 
and then they do what tablegen defined on the second build.  We should avoid 
creating apis that can mislead users.

https://github.com/llvm/llvm-project/pull/115902
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to