================ @@ -702,9 +702,17 @@ ProgramStateRef CStringChecker::CheckOverlap(CheckerContext &C, state->assume(svalBuilder.evalEQ(state, *firstLoc, *secondLoc)); if (stateTrue && !stateFalse) { - // If the values are known to be equal, that's automatically an overlap. - emitOverlapBug(C, stateTrue, First.Expression, Second.Expression); - return nullptr; + if (Filter.CheckCStringBufferOverlap) { + // If the values are known to be equal, that's automatically an overlap. + emitOverlapBug(C, stateTrue, First.Expression, Second.Expression); + return nullptr; + } + // FIXME: We detected a fatal error here, we should stop analysis even if we + // chose not to emit a report here. However, as long as our overlap checker + // is in alpha, lets just pretend nothing happened. ---------------- isuckatcs wrote:
Nit: same as the previous nit about grammar https://github.com/llvm/llvm-project/pull/113312 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits