================ @@ -579,8 +579,14 @@ ProgramStateRef CStringChecker::CheckLocation(CheckerContext &C, // These checks are either enabled by the CString out-of-bounds checker // explicitly or implicitly by the Malloc checker. // In the latter case we only do modeling but do not emit warning. - if (!Filter.CheckCStringOutOfBounds) - return nullptr; + // FIXME: We detected a fatal error here, we should stop analysis even if we + // chose not to emit a report here. However, as long as our out-of-bounds + // checker is in alpha, lets just pretend nothing happened. ---------------- isuckatcs wrote:
```suggestion // FIXME: We detected a fatal error here, and we should stop the analysis even if we // choose not to emit a report here. However, as long as our out-of-bounds // checker is in alpha, let's just pretend that nothing happened. ``` Nit: typos https://github.com/llvm/llvm-project/pull/113312 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits