================
@@ -1,12 +1,14 @@
; This test aims to check ability to support "Arithmetic with Overflow"
intrinsics
; in the special case when those intrinsics are being generated by the
CodeGenPrepare;
-; pass during translations with optimization (note -O3 in llc arguments).
+; pass during translations with optimization (note -disable-lsr, to inhibit
+; strength reduction pre-empting with a more preferable match for this pattern
+; in llc arguments).
-; RUN: llc -O3 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
-; RUN: %if spirv-tools %{ llc -O3 -mtriple=spirv32-unknown-unknown %s -o -
-filetype=obj | spirv-val %}
+; RUN: llc -O3 -disable-lsr -mtriple=spirv32-unknown-unknown %s -o - |
FileCheck %s
----------------
VyacheslavLevytskyy wrote:
Thank you, I also agree that it doesn't seem appropriate to shift attention
from the PR to the test case.
> I'm not exactly sure what loss of coverage you have in mind here
> what the very concrete improvement is in this case
As I've said, "you have explicitly inserted llvm intrinsics in LLVM IR code"
and "you don't have it" means two different starting conditions for the
backend, and different options on how to implement their translation. It's an
implementation detail and is out of this PR's scope. Please feel free to ping
me aside of this discussion in the case if you interested in the subject and
would like to check implementation details and prior discussions.
https://github.com/llvm/llvm-project/pull/110695
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
