nikic wrote: I'm seeing a 0.06% increase in build time with this change. Per-file breakdown: http://llvm-compile-time-tracker.com/compare_clang.php?from=9a227ba3e129eaa89498b97421afefb1e9d681df&to=e354fa543d20a8f50ea678c4cfc7d6dc091ad569&stat=instructions%3Au&sortBy=interestingness
Clearly, this introduces some unnecessary includes. But because of the way the change is done, it will be very hard for reviewers for check that this kind of patch is a strict reduction in the transitive include closure. The way this is usually done is that you remove an individual include from a header and then add any necessary new includes this may require in other files -- with this approach, it is a lot more straightforward to verify the correctness of the change. https://github.com/llvm/llvm-project/pull/102707 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
