amaiorano added a comment. In https://reviews.llvm.org/D28315#639559, @ioeric wrote:
> I ran `ninja check-all` with https://reviews.llvm.org/D28081 and > https://reviews.llvm.org/D28315 (in Linux), and some lit tests failed, namely: > > Clang :: Format/style-on-command-line.cpp > Clang Tools :: clang-apply-replacements/basic.cpp > Clang Tools :: clang-apply-replacements/conflict.cpp > Clang Tools :: clang-apply-replacements/crlf.cpp > Clang Tools :: clang-apply-replacements/format.cpp > Clang Tools :: clang-rename/ClassReplacements.cpp > > > Error message I am seeing: `Expected<T> must be checked before access or > destruction.` > > Could you double check? Thanks! Will definitely double check. Strange that I didn't get these errors on Windows. I did notice in the output that it said one test was disabled. I'll take a closer look asap. ================ Comment at: change-namespace/ChangeNamespace.cpp:892 + llvm::errs() << llvm::toString(Style.takeError()) << "\n"; + continue; + } ---------------- ioeric wrote: > I'd still like to apply replacements that are not cleaned up. Could you add > the following line before continue, thanks! :) > ``` > FileToReplacements[FilePath] = Replaces; > ``` Will do. https://reviews.llvm.org/D28315 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
