amaiorano added a comment.

@ioeric Okay, check-clang-tools passes with my changes.

FYI, tests were originally failing for me (without my changes) because I use 
Git, and it's configured to convert line endings to Windows (crlf) on checkout, 
but some of the tools tests specify extract offsets into source files, which 
end up being incorrect if you've got an extra byte per line ;) I'll open a 
ticket/discussion about it separately.

So if you give me the go ahead, I'll submit this change _after_ submitting 
https://reviews.llvm.org/D28081.


https://reviews.llvm.org/D28315



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to